The simple cases seem to be fixed but I have still got a warning that's wrong:

Layer := nil;

// some code (but no new try statement)

// some more code

finally

end;

I can provide a test case by email if necessary.

• When I introduce a parser error in the .dpr file (e.g. insert '###' in any line), FixInsightCL reports "Failed to parse <file>.dpr", but still exits with zero. Would have expected exit code 1 or 2 here.

• When I introduce a parser error in any of the project files, Fixinsight writes "<file>.pas Fatal parser error" into the log file and exits with zero. Would have expected exit code 1 here.

<? xml version = "1.0"?>
<FixInsightReport version = "2015.04" />

TMyObj = class
private
  FSubObject : TSubObject;
  function GetText: String;
public
  property Text:string read GetText;
end;

function TMyObj.GetText: String;
begin
  try
    Result := FSubObject.Text
  except
    Result := 'Not Assigned';
  end
end;

In an attempt to catch the classic:

begin
  X := TMyObject.Create;
  try
    DoSomethingWith(X);
  finally
    X.Free;
  end;
  ...
  DoSomethingMore;
  ...
  DoSomethingElseWith(X);  <-- A warning would be nice here
end;

Code sample

function UpCaseStr(S:string):string;
var i:integer;
begin
for i := 1 to Length(s) do

s[i]:=ffUpCase(s[i]);
result:=s;
end;