False positive W521
Hi this trigger warning 521. But in else statement Result is set in the for-loop.
function TcxCustomGridRecord.GetLastParentRecordCount: Integer;
begin
if Level = 0 then
Result := 0
else
for Result := 0 to Level - 1 do
if not IsParentRecordLast[Result] then Break;
end;
False positive W521 for record results even though the record is being fully initialized
type
TMatrix = array[0..2, 0..2] of Extended;
function TSomeObject.GetIdentity: TMatrix;
I realize this is very difficult to fix.
Integrate FixInsight into the build process, to show up-to-date warnings each build
FixInsight takes a long time to run, so I don't run it very often. But it's much shorter when it runs only on a few units. So, what about integrating into the compile / build stage, but only running FI on the units that have changed since last time it was run? That way, there are always up-to-date FI messages around, but the overall overhead is small.
[Settings dialog] Wrong Caption
The caption of the settings dialog is after splitting the menu items in Run and Settings still "Run FixInsight..." instead of something like "FixInsight Settings for foo.dproj".
Different behavior of starting FixinsightCL and starting Fixinsight directly from Delphi
When you start Fixinsight directly from Delphi, more units are searched as when you start FixInsightCL. Are there limitations regarding the number of files? Or search paths are not being used correctly?
It might be a good idea to warn when using Sleep(0)
http://joeduffyblog.com/2006/08/22/priorityinduced-starvation-why-sleep1-is-better-than-sleep0-
and-the-windows-balance-set-manager/
The 2015.03 ficfg file format is not upward compatible to the 2015.04 format
The conventions themselves were not turned off separately, so the file looked like this:
<?xml version="1.0" encoding="UTF-8"?>
<FixInsightSettings>
<Rules>
<Rule101 enabled="true">
<Value>50</Value>
</Rule101>
...
<Rule519 enabled="true"/>
</Rules>
<General>
<Conventions enabled="false"/>
<Warnings enabled="true"/>
</General>
</FixInsightSettings>Fixinsight 2015.04 ignores the setting. All rules have to be enabled/disabled separately in the configuration.I would have expected that a config file from an older version which is passed to FixInsight on the command line will lead to the same behaviour on the same and any newer version of FixInsight. If this cannot be the case (the files are incompatible). FixInsight should reject the configuration and error out instead of silently doing something different than before.
Can FixInsight handle concurrency?
On our buildserver, which runs up to four build jobs in parallel, we recently had a few FixInsight failures with exit code 255. What does this exit code mean?
Is it possible that two (or more) instances of FixInsight running at the same time can get into each others way?
Make more use of the right-hand side of the dialog?
Can this be slightly more intuitive, eg having a 'Settings' heading and a label saying 'No settings' for most, and perhaps also showing the same documentation text you have on the website for each warning? It would be useful to select a warning and see a good description of exactly what it checks for.
Move Options/Settings to Tools -> Options...
XE onwards has the ability to have 3rd party settings in Tools -> Options... It would be great if FixInsight should utilise this.
Information about this feature can be found here: http://stackoverflow.com/questions/11241068/how-to-add-my-own-items-in-the-delphi-options-dialog
Customer support service by UserEcho
