This construct was correctly marked with C110 in 2015.11upd2 but is no longer marked in 2015.11upd6

private
  property sNameLogPrefix: string read sGetNameLogPrefixF;

This construct was correctly marked with W507 in 2015.11upd2 but is no longer marked in 2015.11upd6

if xRight then
  TextOut(Round((YAchse.RectTitle.Right + YAchse.RectTitle.Left - TextExtent(sValue).cy) / 2),
          Round((YAchse.RectTitle.Bottom + YAchse.RectTitle.Top + TextExtent(sValue).cx) / 2), sValue)
else
  TextOut(Round((YAchse.RectTitle.Right + YAchse.RectTitle.Left - TextExtent(sValue).cy) / 2),
          Round((YAchse.RectTitle.Bottom + YAchse.RectTitle.Top + TextExtent(sValue).cx) / 2), sValue);

Warning on unused parameters in a method call

This is difficult because of virtual methods and event handlers, etc Too often you don't use a parameter but you must declare it.

Yesterday we came accross a "nice" bug in our software which was hidden by inherited calls in constructors/destructors not being symmetrical.

constructor x.create;
begin
  inherited;
  CreateLocalObjects;
end;

destructor x.destroy;
begin
  inherited; <-- possible ouch
  CleanupLocalObjects;
end;

Most of the time nothing bad happens here if it's just basic create and destroy of local objects, but if "CleanupLocalObjects" touches anything belonging to the inherited object, unpredictable results may happen.

Would it be possible to add the following two conventions:

• the inherited call in a constructor should be the first statement after "begin"
• the inherited call in a destructor should be the last statement before "end"

And another one, better hidden this time :)

In my particular case FMyObject is an XML Node with a 'Text' child node, whose 'Text' property is returned. Simple example:

function TObject.GetText: String;
begin
  Result := FSubObject.Text.Text
end;

It's clear that in this case it is not the TObject.Text property which is accessed and may cause a recursion. It is the subsubobjects text property :)

I think W527 should just trigger on these two cases:

function TObject.GetText: String;
begin
  Result := Text
end;

function TObject.GetText: String;
begin
  Result := Self.Text
end;

Or did I miss something?

I have not tried what FixInsight reports, when FMyObject is an XML Node with a 'XYZ' child node, whose 'Text' property is returned or if FMyObject is an XML Node with a 'Text' child node, whose 'XYZ' property is returned.

function TObject.GetText: String;
begin
  Result := FSubObject.XYZ.Text
end;

function TObject.GetText: String;
begin
  Result := FSubObject.Text.XYZ
end;

(very simplistic) example:

type

TMyObject = class

private

const

cTEST = 20;

private

procedure MyMethod;

end;

procedure TMyObject.MyMethod;

const

cTEST = 30;

begin

ShowMessage(IntToStr(cTEST));

end;

A warning should appear on "cTEST = 30;" saying that it hides "cTEST = 20;"

Maybe an extension to http://fixinsight.userecho.com/topic/1052114-hint-on-unnecessary-beginend-block/, in that for Win32, try-finally set ups are expensive, so removing them would make the application perform better.